Update version to 0.2.6.4-STABLE, add ExampleUsages class, and implem…#29
Merged
Conversation
…ent asynchronous job execution
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates ConnectLib to version 0.2.6.4-STABLE with a major architectural change to support asynchronous job execution. The primary purpose is to refactor the API response handling from synchronous blocking operations to reactive streams using Project Reactor's Mono type.
- Refactored
getResponse()method to returnMono<ApiFactory>instead ofApiFactoryfor asynchronous execution - Added comprehensive example usage class demonstrating both synchronous and asynchronous patterns
- Removed deprecated convenience methods from JobGetInfos class to simplify the API
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/fr/sandro642/github/jobs/JobGetInfos.java | Refactored getResponse() to return Mono and removed deprecated convenience methods |
| src/test/java/fr/sandro642/github/test/MainTest.java | Updated test methods to handle new asynchronous API with CompletableFuture and .block() operations |
| src/main/java/fr/sandro642/github/example/ExampleUsages.java | Added new example class with comprehensive usage patterns for both sync and async operations |
| readme.md | Updated version references and documentation links |
Comments suppressed due to low confidence (1)
src/main/java/fr/sandro642/github/example/ExampleUsages.java:97
- [nitpick] Inconsistent spacing in generic type declaration. Should be 'Map<String, ?>' to match the spacing used in line 96.
Map<String,?> params = Map.of();
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent asynchronous job execution